agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Allow PostgreSQL::Test::Cluster::start() to pass postmaster opti
Date: Mon, 20 Jul 2026 12:43:19 +0000
Message-ID: <E1wlnL5-000000001k0-1Z7x@gemulon.postgresql.org> (raw)
Allow PostgreSQL::Test::Cluster::start() to pass postmaster options
Previously, tests that needed extra postmaster command-line options had
to invoke pg_ctl start directly, because
PostgreSQL::Test::Cluster::start() provided no way to pass them. That
bypassed the test framework's postmaster PID tracking, so a postmaster
could be left running if the test failed after startup.
Add an options parameter to
PostgreSQL::Test::Cluster::start(), which is passed to pg_ctl's
--options argument. This allows tests to use start() while
preserving the framework's normal cleanup behavior.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: JoongHyuk Shin <sjh910805@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwEpfE0CDUUODjBt7GO9U4ZF11hqga_Ci3wP8=O49oFKVw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1009339b3acaf06b457a8182bf50b504847a643c
Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
Message-ID: <E1wlnL5-000000001k0-1Z7x@gemulon.postgresql.org>
Permalink: ../E1wlnL5-000000001k0-1Z7x@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wlnL5-000000001k0-1Z7x@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow PostgreSQL::Test::Cluster::start() to pass postmaster opti
In-Reply-To: <E1wlnL5-000000001k0-1Z7x@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox