agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix recovery target test waiting on unavailable WAL
Date: Mon, 20 Jul 2026 18:28:05 +0000
Message-ID: <E1wlsij-000000003oZ-0bcX@gemulon.postgresql.org> (raw)
Fix recovery target test waiting on unavailable WAL
Buildfarm member skink reported a failure in
recovery/003_recovery_targets after commit d5751c33cc3. The newly
added recovery_target_xid set-then-cleared test could time out while
waiting for pg_last_wal_replay_lsn() to reach the expected LSN.
The test recorded lsn6 after calling pg_switch_wal(). As a result,
lsn6 pointed into the next WAL segment, but pg_switch_wal() only
archived the previous one. Since the standby in this test restores WAL
from the archive only, it could not obtain the segment containing
lsn6 and waited indefinitely.
Fix this by recording lsn6 before calling pg_switch_wal(), so the
archived WAL contains the LSN that the standby is waiting for.
Per buildfarm member skink.
Reported-by: Álvaro Herrera <alvherre@kurilemu.de>
Author: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/al5Y2mWffRs1NP34@alvherre.pgsql
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/83486b6a65aa48ed18e4e872d5e0fb5b0bfaca41
Modified Files
--------------
src/test/recovery/t/003_recovery_targets.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Message-ID: <E1wlsij-000000003oZ-0bcX@gemulon.postgresql.org>
Permalink: ../E1wlsij-000000003oZ-0bcX@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wlsij-000000003oZ-0bcX@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix recovery target test waiting on unavailable WAL
In-Reply-To: <E1wlsij-000000003oZ-0bcX@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox