agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix EXCEPT publication test to check subscriber
Date: Fri, 24 Jul 2026 06:47:41 +0000
Message-ID: <E1wn9h7-000000005cP-36i8@gemulon.postgresql.org> (raw)
Fix EXCEPT publication test to check subscriber
Commit fd366065e06 added tests intended to verify that rows inserted
on the publisher are replicated to the subscriber when using multiple
publications, with one excluding the target table via EXCEPT and
another including it.
However, the tests queried the publisher instead of the subscriber.
Since the rows were inserted directly into the publisher, the checks
would always succeed, providing no coverage of replication.
Fix this by querying the subscriber so the tests verify the replicated
state.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwGfXUO7f4t6KNGurYwg6QsnLtpP0K3EACbAwYWtxGfKfQ@mail.gmail.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/72207b17daa328d83b1609b4bc5cc4047fe4ba01
Modified Files
--------------
src/test/subscription/t/037_except.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
view thread (2+ messages)
Message-ID: <E1wn9h7-000000005cP-36i8@gemulon.postgresql.org>
Permalink: ../E1wn9h7-000000005cP-36i8@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wn9h7-000000005cP-36i8@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix EXCEPT publication test to check subscriber
In-Reply-To: <E1wn9h7-000000005cP-36i8@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox