agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid reporting permission-denied publisher sequences as missing
Date: Sat, 25 Jul 2026 01:33:09 +0000
Message-ID: <E1wnRGH-00000000Bq7-2HyG@gemulon.postgresql.org> (raw)
Avoid reporting permission-denied publisher sequences as missing
Previously, if a sequence synchronization batch contained both a sequence
that had been dropped on the publisher and another for which the
replication role lacked SELECT privilege, the latter was reported
twice: once as a permission failure and again as missing on the
publisher.
This happened because the permission-denied sequence was not marked as
found on the publisher. As a result, when another sequence in the batch
was genuinely missing, the later missing-sequence check incorrectly
classified the permission-denied sequence as missing as well.
Fix this by marking the permission-denied sequence as found before
reporting the permission failure, so it is not later reported as
missing.
Reported-by: Noah Misch <noah@leadboat.com>
Author: Vignesh C <vignesh21@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CALDaNm3LsUjW7PahuCsbYAxajSF+S328tw5E9rF0erdh7dKOXw@mail.gmail.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/13b7a8a0ef56d9decae284b4983894175c17d217
Modified Files
--------------
src/backend/replication/logical/sequencesync.c | 20 ++++++++++++++++++--
1 file changed, 18 insertions(+), 2 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wnRGH-00000000Bq7-2HyG@gemulon.postgresql.org>
Permalink: ../E1wnRGH-00000000Bq7-2HyG@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wnRGH-00000000Bq7-2HyG@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid reporting permission-denied publisher sequences as missing
In-Reply-To: <E1wnRGH-00000000Bq7-2HyG@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox