agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Deparse FOR PORTION OF using the range column's current name.
Date: Mon, 27 Jul 2026 13:37:14 +0000
Message-ID: <E1woLW6-00000000WVK-0a6i@gemulon.postgresql.org> (raw)
Deparse FOR PORTION OF using the range column's current name.
Commit 8e72d914c recorded the range column's name in ForPortionOfExpr
and used that for deparsing FOR PORTION OF. This gives the wrong
answer if the ForPortionOfExpr is saved in a rule or SQL function and
then the column gets renamed. Drop the ForPortionOfExpr.range_name
field; instead fetch the current column name from the catalogs when
needed.
Also drop ForPortionOfState.fp_rangeName, which wasn't being used
anywhere.
Full disclosure: an earlier draft of this patch was made with
Claude Opus 4.8.
Reported-by: John Naylor <johncnaylorls@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CANWCAZYFEpJ5Oi45gi4q9Y6LYa4_oiAXxuNNWe-1ym-i0fF8Pw@mail.gmail.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/2a9541ddfd3a5b069c505e36a91f289126871a21
Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 2 --
src/backend/optimizer/plan/planner.c | 4 +++-
src/backend/parser/analyze.c | 1 -
src/backend/utils/adt/ruleutils.c | 15 +++++++++----
src/include/catalog/catversion.h | 2 +-
src/include/nodes/execnodes.h | 1 -
src/include/nodes/primnodes.h | 1 -
src/test/regress/expected/for_portion_of.out | 33 ++++++++++++++++++++++++++++
src/test/regress/sql/for_portion_of.sql | 16 ++++++++++++++
9 files changed, 64 insertions(+), 11 deletions(-)
view thread (2+ messages)
Message-ID: <E1woLW6-00000000WVK-0a6i@gemulon.postgresql.org>
Permalink: ../E1woLW6-00000000WVK-0a6i@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1woLW6-00000000WVK-0a6i@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Deparse FOR PORTION OF using the range column's current name.
In-Reply-To: <E1woLW6-00000000WVK-0a6i@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox