agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix portability issue in authentication test 003_peer
Date: Tue, 28 Jul 2026 02:10:55 +0000
Message-ID: <E1woXHT-00000000arT-02Eo@gemulon.postgresql.org> (raw)
Fix portability issue in authentication test 003_peer
The mapped user name is built upon the OS user name of the environment
where the test is run. Depending on the characters used in the OS user
name, CREATE ROLE may not get parsed (the author has mentioned hyphens
as one case), causing a failure of the test.
Let's use double-quotes around the mapped user name, which should be a
solution good enough for the environments where this test tends to run.
The buildfarm issued no complaint over the years.
Oversight in 3c4e26a62c31, so backpatch down to v19. Perhaps
3c4e26a62c31 and this commit should be backpatched further down, but
let's leave that for another day, if it proves necessary.
Author: Yugo Nagata <nagata@sraoss.co.jp>
Discussion: https://postgr.es/m/20260727133857.fbd23d43d422f10f376a8bee@sraoss.co.jp
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/123ea94f76b8efc9f45286e2ba55ee02bff5056c
Modified Files
--------------
src/test/authentication/t/003_peer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
view thread (2+ messages)
Message-ID: <E1woXHT-00000000arT-02Eo@gemulon.postgresql.org>
Permalink: ../E1woXHT-00000000arT-02Eo@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1woXHT-00000000arT-02Eo@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix portability issue in authentication test 003_peer
In-Reply-To: <E1woXHT-00000000arT-02Eo@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox