agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Handle invalid and dropped databases during checksum enable
Date: Tue, 28 Jul 2026 19:58:40 +0000
Message-ID: <E1wonwm-00000000hfk-1R61@gemulon.postgresql.org> (raw)
Handle invalid and dropped databases during checksum enable
Enable errors out early with a hint when an invalid database exists,
since the worker cannot connect to it and its files stay on disk.
A worker that started but failed gets the same dropped-database
heuristic as one that failed to start, so a concurrent drop during
processing no longer aborts the whole run. The existence check locks
the database first, otherwise a DROP DATABASE ... WITH (FORCE) which
killed the worker is still only halfway done and the database looks
like it is there to stay.
Backpatch to v19 where online checksums were introduced.
Author: Zsolt Parragi <zsolt.parragi@percona.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/CAN4CZFOGdqxtZ5-6gb4apqmvoH=Z+TNH8RKJ3mVtoR1HirKQWg@mail.gmail.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/51f55b13a4d3621244b3645a506b006decca0ec2
Modified Files
--------------
src/backend/postmaster/datachecksum_state.c | 71 +++++++++++++++
src/test/modules/test_checksums/t/001_basic.pl | 121 +++++++++++++++++++++++++
2 files changed, 192 insertions(+)
view thread (2+ messages) latest in thread
Message-ID: <E1wonwm-00000000hfk-1R61@gemulon.postgresql.org>
Permalink: ../E1wonwm-00000000hfk-1R61@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wonwm-00000000hfk-1R61@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Handle invalid and dropped databases during checksum enable
In-Reply-To: <E1wonwm-00000000hfk-1R61@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox