agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid accumulating relation locks during sequence synchronizatio
Date: Wed, 29 Jul 2026 04:23:18 +0000
Message-ID: <E1wovp8-00000000kl0-19Uj@gemulon.postgresql.org> (raw)
Avoid accumulating relation locks during sequence synchronization.
While collecting the sequences to synchronize, the sequence sync worker
opened each INIT sequence with RowExclusiveLock and held it until the
transaction committed. With many such sequences, this could exhaust the
shared lock table and fail with "out of shared memory".
The worker only reads each sequence's identity (namespace and name) here
and needs it to stay stable while read, for which AccessShareLock is
enough, as it conflicts with the AccessExclusiveLock taken by DROP,
RENAME, and SET SCHEMA. Take that lock instead and release it as soon as
the identity is read. The later synchronization re-opens each sequence, so
it does not rely on the lock being retained.
Reported-by: Noah Misch <noah@leadboat.com>
Author: vignesh C <vignesh21@gmail.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 19, where it was introduced
Discussion: https://postgr.es/m/20260710045217.f0.noahmisch@microsoft.com
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e46c2a65710f021e25bc0fcf404dd00c86aec1d7
Modified Files
--------------
src/backend/replication/logical/sequencesync.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
view thread (2+ messages)
Message-ID: <E1wovp8-00000000kl0-19Uj@gemulon.postgresql.org>
Permalink: ../E1wovp8-00000000kl0-19Uj@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wovp8-00000000kl0-19Uj@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid accumulating relation locks during sequence synchronizatio
In-Reply-To: <E1wovp8-00000000kl0-19Uj@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox