agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Protect PGPROC lookup when terminating background workers
Date: Wed, 29 Jul 2026 08:40:05 +0000
Message-ID: <E1wozpd-00000000m7X-3CM0@gemulon.postgresql.org> (raw)
Protect PGPROC lookup when terminating background workers
TerminateBackgroundWorkersForDatabase() uses BackendPidGetProc() and,
until now, accessed fields of the returned PGPROC after releasing
ProcArrayLock, including its database OID. If the PGPROC slot is
recycled during this window, the database OID being checked may belong
to a different backend, causing an unrelated background worker to be
terminated.
Triggering this bug requires a very narrow race: the background worker
identified by BackendPidGetProc() must exit, its PGPROC slot must be
released and reused, and only then must
TerminateBackgroundWorkersForDatabase() examine the database OID.
TerminateBackgroundWorkersForDatabase() holds BackgroundWorkerLock,
preventing parallel workers and dynamically registered workers (such as
those created by worker_spi) from reusing the slot. As far as I know,
the only plausible scenario is a static background worker that exits and
is restarted quickly enough to reuse the same PGPROC slot within the
race window. In practice, this race is extremely unlikely, still
reachable in theory.
Oversight in f1e251be80a0.
Author: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Aya Iwata <iwata.aya@fujitsu.com>
Reviewed-by: Haibo Yan <tristan.yim@gmail.com>
Discussion: https://postgr.es/m/78E81763-EA1D-4788-9741-4092BCB997A5@gmail.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/16c3435794befad6499449cbd73696f6d3ca8e24
Modified Files
--------------
src/backend/postmaster/bgworker.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
view thread (2+ messages)
Message-ID: <E1wozpd-00000000m7X-3CM0@gemulon.postgresql.org>
Permalink: ../E1wozpd-00000000m7X-3CM0@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wozpd-00000000m7X-3CM0@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Protect PGPROC lookup when terminating background workers
In-Reply-To: <E1wozpd-00000000m7X-3CM0@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox