agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix stale comment in parallel_vacuum_main().
Date: Wed, 29 Jul 2026 16:52:33 +0000
Message-ID: <E1wp7WD-00000000otb-3wBE@gemulon.postgresql.org> (raw)
Fix stale comment in parallel_vacuum_main().
The comment claimed that a parallel vacuum worker has only the
PROC_IN_VACUUM flag because parallel vacuum is not supported for
autovacuum, but commit 1ff3180ca01 allowed autovacuum to use parallel
vacuum workers.
The assertion itself still holds: the leader, whether a backend
running VACUUM or an autovacuum worker, sets PROC_IN_VACUUM before
taking its snapshot, and a parallel worker inherits the flag when
importing the leader's snapshot. The leader's other flags don't reach
the worker, since the snapshot import copies only the PROC_XMIN_FLAGS
bits and PROC_IS_AUTOVACUUM is never set on parallel workers, which
run as regular background workers. Reword the comment to explain that.
Oversight in commit 1ff3180ca01.
Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CALj2ACVwQ4WABqq8Lnf+VZEJ45jcTFhyFLFr_ctfS4=QLL-r5w@mail.gmail.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a84eca6627fe02d1e299b9a80dc4cb82a0b557ff
Modified Files
--------------
src/backend/commands/vacuumparallel.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wp7WD-00000000otb-3wBE@gemulon.postgresql.org>
Permalink: ../E1wp7WD-00000000otb-3wBE@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wp7WD-00000000otb-3wBE@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix stale comment in parallel_vacuum_main().
In-Reply-To: <E1wp7WD-00000000otb-3wBE@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox