agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix SystemTap dtrace warning about smgr probe argument types.
Date: Thu, 30 Jul 2026 00:26:00 +0000
Message-ID: <E1wpEb2-00000000sRv-1ExI@gemulon.postgresql.org> (raw)
Fix SystemTap dtrace warning about smgr probe argument types.
Commits ca326e903 and 1f8c504e3 widened the byte-count arguments of
smgr__md__read__done and smgr__md__write__done to "long long int".
SystemTap's dtrace(1) fails on that specific spelling and falls back
with a warning (misreported near the previous probe). Use ssize_t
and size_t instead, matching the md.c call sites.
Revise probes.d's note about which types are usable as probe
arguments: recommend using system-supplied type names (macOS dtrace
rejects names like PostgreSQL's uint64), and call out "long long int"
as a known SystemTap failure case rather than a wider failure mode.
Also, update the monitoring.sgml entries for these probes,
which were missed by the prior commits.
Reported-by: Laurenz Albe <laurenz.albe@cybertec.at>
Author: Andrey Rachitskiy <pl0h0yp1@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/697d3c88568442cd637d8453d129f1bb14bbd2a8.camel@cybertec.at
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8f191a79617d906e34d041382e6ecfbf78166a65
Modified Files
--------------
doc/src/sgml/monitoring.sgml | 4 ++--
src/backend/utils/probes.d | 14 ++++++++++----
2 files changed, 12 insertions(+), 6 deletions(-)
Message-ID: <E1wpEb2-00000000sRv-1ExI@gemulon.postgresql.org>
Permalink: ../E1wpEb2-00000000sRv-1ExI@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wpEb2-00000000sRv-1ExI@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix SystemTap dtrace warning about smgr probe argument types.
In-Reply-To: <E1wpEb2-00000000sRv-1ExI@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox