agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix background psql session cleanup in 051_effective_wal_level.p
Date: Thu, 30 Jul 2026 23:17:37 +0000
Message-ID: <E1wpa0P-000000010k6-1RDY@gemulon.postgresql.org> (raw)
Fix background psql session cleanup in 051_effective_wal_level.pl.
Commit 6aba42c660c added quit() calls for two background psql sessions
whose slot creation is canceled by pg_cancel_backend(). Both sessions
ran with the default ON_ERROR_STOP=1 and ended their script with \q,
so psql exited as soon as the cancellation error arrived. quit() then
wrote another \q to the already-closed pipe, making the test die with
"ack Broken pipe".
Run both sessions with on_error_stop => 0 and drop the trailing \q, so
that psql stays at the prompt after reporting the error and quit() can
shut it down cleanly.
Discussion: https://postgr.es/m/CAD21AoCZY1fKYgfkvHGWGiXpatUKd23FSLnDCL4m9bWFjdXNZw@mail.gmail.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5c808b8c5c395a7d7afea7efaaa3328b4bc4e004
Modified Files
--------------
src/test/recovery/t/051_effective_wal_level.pl | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
view thread (2+ messages)
Message-ID: <E1wpa0P-000000010k6-1RDY@gemulon.postgresql.org>
Permalink: ../E1wpa0P-000000010k6-1RDY@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wpa0P-000000010k6-1RDY@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix background psql session cleanup in 051_effective_wal_level.p
In-Reply-To: <E1wpa0P-000000010k6-1RDY@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox