agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve wording of sequence origin warning in logical replicatio
Date: Fri, 31 Jul 2026 04:35:40 +0000
Message-ID: <E1wpeyC-000000012r8-1jmE@gemulon.postgresql.org> (raw)
Improve wording of sequence origin warning in logical replication.
check_publications_origin_sequences() warns when a subscription with
origin = NONE synchronizes sequence values that may have originated from
another subscription. The existing warning is phrased in terms of
copy_data and copying data, which is appropriate for table synchronization
but misleading for sequence synchronization.
Reword the warning, detail, and hint to describe sequence synchronization
and the associated origin = NONE semantics more accurately.
Also fix a typo ("rathen" -> "rather") in a comment in sequencesync.c.
Reported-by: Noah Misch <noah@leadboat.com>
Reported-by: Peter Smith <smithpb2250@gmail.com>
Author: vignesh C <vignesh21@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 19, where it was introduced
Discussion: https://postgr.es/m/20260710045217.f0.noahmisch@microsoft.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/00b3e50054dad648e74d19cc199555381ab366d2
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 8 ++++----
src/backend/replication/logical/sequencesync.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wpeyC-000000012r8-1jmE@gemulon.postgresql.org>
Permalink: ../E1wpeyC-000000012r8-1jmE@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wpeyC-000000012r8-1jmE@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve wording of sequence origin warning in logical replicatio
In-Reply-To: <E1wpeyC-000000012r8-1jmE@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox