agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedpgsql: Improve wording of sequence origin warning in logical replicatio
2+ messages / 1 participants
[nested] [flat]
* pgsql: Improve wording of sequence origin warning in logical replicatio
@ 2026-07-31 04:35 Amit Kapila <akapila@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: Amit Kapila @ 2026-07-31 04:35 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Improve wording of sequence origin warning in logical replication.
check_publications_origin_sequences() warns when a subscription with
origin = NONE synchronizes sequence values that may have originated from
another subscription. The existing warning is phrased in terms of
copy_data and copying data, which is appropriate for table synchronization
but misleading for sequence synchronization.
Reword the warning, detail, and hint to describe sequence synchronization
and the associated origin = NONE semantics more accurately.
Also fix a typo ("rathen" -> "rather") in a comment in sequencesync.c.
Reported-by: Noah Misch <noah@leadboat.com>
Reported-by: Peter Smith <smithpb2250@gmail.com>
Author: vignesh C <vignesh21@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 19, where it was introduced
Discussion: https://postgr.es/m/20260710045217.f0.noahmisch@microsoft.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/00b3e50054dad648e74d19cc199555381ab366d2
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 8 ++++----
src/backend/replication/logical/sequencesync.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Improve wording of sequence origin warning in logical replicatio
@ 2026-07-31 04:35 Amit Kapila <akapila@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: Amit Kapila @ 2026-07-31 04:35 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Improve wording of sequence origin warning in logical replication.
check_publications_origin_sequences() warns when a subscription with
origin = NONE synchronizes sequence values that may have originated from
another subscription. The existing warning is phrased in terms of
copy_data and copying data, which is appropriate for table synchronization
but misleading for sequence synchronization.
Reword the warning, detail, and hint to describe sequence synchronization
and the associated origin = NONE semantics more accurately.
Also fix a typo ("rathen" -> "rather") in a comment in sequencesync.c.
Reported-by: Noah Misch <noah@leadboat.com>
Reported-by: Peter Smith <smithpb2250@gmail.com>
Author: vignesh C <vignesh21@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 19, where it was introduced
Discussion: https://postgr.es/m/20260710045217.f0.noahmisch@microsoft.com
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c7d8049682d623109a40de0c84d68e114c013c26
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 8 ++++----
src/backend/replication/logical/sequencesync.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-07-31 04:35 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-31 04:35 pgsql: Improve wording of sequence origin warning in logical replicatio Amit Kapila <akapila@postgresql.org>
2026-07-31 04:35 pgsql: Improve wording of sequence origin warning in logical replicatio Amit Kapila <akapila@postgresql.org>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox