agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix missing space before WHERE in GRAPH_TABLE deparse
Date: Mon, 03 Aug 2026 08:33:05 +0000
Message-ID: <E1wqo6b-00000001TFT-01AR@gemulon.postgresql.org> (raw)
Fix missing space before WHERE in GRAPH_TABLE deparse
get_graph_pattern_def() emitted the pattern-level WHERE keyword as
"WHERE " with no leading space, so reverse-parsing produced output
like "(o IS orders)WHERE (...)". The element-level WHERE deparse in
get_path_pattern_expr_def() already prepends a separating space; the
pattern-level branch was inconsistent with it. Emit " WHERE " to
match.
The output still re-parses to the same tree, so this is cosmetic.
For test coverage, add a whole-pattern WHERE clause to the existing
customers_us view, which is already reverse-parsed with
pg_get_viewdef().
Author: Dhruv Chauhan <chauhandhruv351@gmail.com>
Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CANWwWcpHb0h7tg6otRnL-FV83jwQpAiyw1bhvv8T78kpwZ-0ow%40mai...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/780fa49746d57403b871f4ef4c92499b324df32c
Modified Files
--------------
src/backend/utils/adt/ruleutils.c | 2 +-
src/test/regress/expected/graph_table.out | 21 +++++++++++----------
src/test/regress/sql/graph_table.sql | 5 +++--
3 files changed, 15 insertions(+), 13 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wqo6b-00000001TFT-01AR@gemulon.postgresql.org>
Permalink: ../E1wqo6b-00000001TFT-01AR@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wqo6b-00000001TFT-01AR@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix missing space before WHERE in GRAPH_TABLE deparse
In-Reply-To: <E1wqo6b-00000001TFT-01AR@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox