agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Álvaro Herrera <alvherre@kurilemu.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove unused arg and dead code in set_attnotnull()
Date: Mon, 03 Aug 2026 11:53:47 +0000
Message-ID: <E1wqrEp-000000000L6-3tx8@gemulon.postgresql.org> (raw)

Remove unused arg and dead code in set_attnotnull()

The is_valid parameter was never referenced in the function body, and
the 'thisatt' local variable is set but never used.  Remove both.

Oversight in a379061a22a8.

Author: Sami Imseih <samimseih@gmail.com>
Backpatch-through: 18
Discussion: https://postgr.es/m/CAA5RZ0tHnvSrfUy4jWJchjvkL_aJe0hCnZpMsFRdLrSxCne5qQ@mail.gmail.com

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1d24c588975a3982720cd7874496d1dffb83d292

Modified Files
--------------
src/backend/commands/tablecmds.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1wqrEp-000000000L6-3tx8@gemulon.postgresql.org>
Permalink:  ../E1wqrEp-000000000L6-3tx8@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wqrEp-000000000L6-3tx8@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@kurilemu.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove unused arg and dead code in set_attnotnull()
  In-Reply-To: <E1wqrEp-000000000L6-3tx8@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox