agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Fix lock release for role membership grants in DROP OWNED BY. 5+ messages / 1 participants [nested] [flat]
* pgsql: Fix lock release for role membership grants in DROP OWNED BY. @ 2026-08-03 19:33 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Jeff Davis @ 2026-08-03 19:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lock release for role membership grants in DROP OWNED BY. Commit 6566133c5f5 added a case for AuthMemRelationId in AcquireDeletionLock(), but not ReleaseDeletionLock(). The fall-through case would go to UnlockDatabaseObject(), which would raise a WARNING; and the lock would be retained until the end of the transaction. Add the missing branch. Discussion: https://postgr.es/m/2487ddcd737d4fc8e408e87aa9ad4365eed3bbb3.camel@j-davis.com Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b48caa7dfde8991ee09226593c381bd3442297dc Modified Files -------------- src/backend/catalog/dependency.c | 3 +++ src/test/isolation/expected/drop-owned-grant.out | 8 +++++++ src/test/isolation/isolation_schedule | 1 + src/test/isolation/specs/drop-owned-grant.spec | 30 ++++++++++++++++++++++++ 4 files changed, 42 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix lock release for role membership grants in DROP OWNED BY. @ 2026-08-03 19:34 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Jeff Davis @ 2026-08-03 19:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lock release for role membership grants in DROP OWNED BY. Commit 6566133c5f5 added a case for AuthMemRelationId in AcquireDeletionLock(), but not ReleaseDeletionLock(). The fall-through case would go to UnlockDatabaseObject(), which would raise a WARNING; and the lock would be retained until the end of the transaction. Add the missing branch. Discussion: https://postgr.es/m/2487ddcd737d4fc8e408e87aa9ad4365eed3bbb3.camel@j-davis.com Backpatch-through: 16 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9eccdae22aca63360c48f5005d062a1684f017af Modified Files -------------- src/backend/catalog/dependency.c | 3 +++ src/test/isolation/expected/drop-owned-grant.out | 8 +++++++ src/test/isolation/isolation_schedule | 1 + src/test/isolation/specs/drop-owned-grant.spec | 30 ++++++++++++++++++++++++ 4 files changed, 42 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix lock release for role membership grants in DROP OWNED BY. @ 2026-08-03 19:34 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Jeff Davis @ 2026-08-03 19:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lock release for role membership grants in DROP OWNED BY. Commit 6566133c5f5 added a case for AuthMemRelationId in AcquireDeletionLock(), but not ReleaseDeletionLock(). The fall-through case would go to UnlockDatabaseObject(), which would raise a WARNING; and the lock would be retained until the end of the transaction. Add the missing branch. Discussion: https://postgr.es/m/2487ddcd737d4fc8e408e87aa9ad4365eed3bbb3.camel@j-davis.com Backpatch-through: 16 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a0daa0b4127dffe99a92c6606ad778f89ec3239f Modified Files -------------- src/backend/catalog/dependency.c | 3 +++ src/test/isolation/expected/drop-owned-grant.out | 8 +++++++ src/test/isolation/isolation_schedule | 1 + src/test/isolation/specs/drop-owned-grant.spec | 30 ++++++++++++++++++++++++ 4 files changed, 42 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix lock release for role membership grants in DROP OWNED BY. @ 2026-08-03 19:34 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Jeff Davis @ 2026-08-03 19:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lock release for role membership grants in DROP OWNED BY. Commit 6566133c5f5 added a case for AuthMemRelationId in AcquireDeletionLock(), but not ReleaseDeletionLock(). The fall-through case would go to UnlockDatabaseObject(), which would raise a WARNING; and the lock would be retained until the end of the transaction. Add the missing branch. Discussion: https://postgr.es/m/2487ddcd737d4fc8e408e87aa9ad4365eed3bbb3.camel@j-davis.com Backpatch-through: 16 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/25e54cec72ae30809a2fdf6fdf2b1f726bd9142a Modified Files -------------- src/backend/catalog/dependency.c | 3 +++ src/test/isolation/expected/drop-owned-grant.out | 8 +++++++ src/test/isolation/isolation_schedule | 1 + src/test/isolation/specs/drop-owned-grant.spec | 30 ++++++++++++++++++++++++ 4 files changed, 42 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix lock release for role membership grants in DROP OWNED BY. @ 2026-08-03 19:34 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Jeff Davis @ 2026-08-03 19:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lock release for role membership grants in DROP OWNED BY. Commit 6566133c5f5 added a case for AuthMemRelationId in AcquireDeletionLock(), but not ReleaseDeletionLock(). The fall-through case would go to UnlockDatabaseObject(), which would raise a WARNING; and the lock would be retained until the end of the transaction. Add the missing branch. Discussion: https://postgr.es/m/2487ddcd737d4fc8e408e87aa9ad4365eed3bbb3.camel@j-davis.com Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e61d44fdee7e299dcbd4e168bda1e6670680aebc Modified Files -------------- src/backend/catalog/dependency.c | 3 +++ src/test/isolation/expected/drop-owned-grant.out | 8 +++++++ src/test/isolation/isolation_schedule | 1 + src/test/isolation/specs/drop-owned-grant.spec | 30 ++++++++++++++++++++++++ 4 files changed, 42 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-08-03 19:34 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-03 19:33 pgsql: Fix lock release for role membership grants in DROP OWNED BY. Jeff Davis <jdavis@postgresql.org> 2026-08-03 19:34 pgsql: Fix lock release for role membership grants in DROP OWNED BY. Jeff Davis <jdavis@postgresql.org> 2026-08-03 19:34 pgsql: Fix lock release for role membership grants in DROP OWNED BY. Jeff Davis <jdavis@postgresql.org> 2026-08-03 19:34 pgsql: Fix lock release for role membership grants in DROP OWNED BY. Jeff Davis <jdavis@postgresql.org> 2026-08-03 19:34 pgsql: Fix lock release for role membership grants in DROP OWNED BY. Jeff Davis <jdavis@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox