agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix lock release for role membership grants in DROP OWNED BY.
Date: Mon, 03 Aug 2026 19:34:26 +0000
Message-ID: <E1wqyQc-000000003MA-2EkW@gemulon.postgresql.org> (raw)

Fix lock release for role membership grants in DROP OWNED BY.

Commit 6566133c5f5 added a case for AuthMemRelationId in
AcquireDeletionLock(), but not ReleaseDeletionLock(). The fall-through
case would go to UnlockDatabaseObject(), which would raise a WARNING;
and the lock would be retained until the end of the transaction.

Add the missing branch.

Discussion: https://postgr.es/m/2487ddcd737d4fc8e408e87aa9ad4365eed3bbb3.camel@j-davis.com
Backpatch-through: 16

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/25e54cec72ae30809a2fdf6fdf2b1f726bd9142a

Modified Files
--------------
src/backend/catalog/dependency.c                 |  3 +++
src/test/isolation/expected/drop-owned-grant.out |  8 +++++++
src/test/isolation/isolation_schedule            |  1 +
src/test/isolation/specs/drop-owned-grant.spec   | 30 ++++++++++++++++++++++++
4 files changed, 42 insertions(+)



view thread (5+ messages)  latest in thread

Message-ID: <E1wqyQc-000000003MA-2EkW@gemulon.postgresql.org>
Permalink:  ../E1wqyQc-000000003MA-2EkW@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wqyQc-000000003MA-2EkW@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix lock release for role membership grants in DROP OWNED BY.
  In-Reply-To: <E1wqyQc-000000003MA-2EkW@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox