agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix error handling in getCopyDataMessage() and pqFunctionCall3()
Date: Tue, 04 Aug 2026 08:10:11 +0000
Message-ID: <E1wrADz-000000008WB-0AZI@gemulon.postgresql.org> (raw)
Fix error handling in getCopyDataMessage() and pqFunctionCall3()
Commit f6f0542266f0 changed getNotify(),
getParameterStatus(), and related libpq message-processing paths to
abandon the connection on out-of-memory errors.
However, getCopyDataMessage() and pqFunctionCall3() did not handle
this new fatal-error state. Both can process asynchronous
NotificationResponse and ParameterStatus messages while waiting for
other responses. If one of those messages triggered a fatal error, these
loops continued processing instead of reporting it immediately.
Fix this by checking for a saved fatal error after processing an
asynchronous message. If the connection has been abandoned, return the
appropriate error immediately instead of continuing to parse input.
Backpatch to v18, where commit f6f0542266f0 introduced this issue.
Author: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Reviewed-by: Ewan Young <kdbase.hack@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CAO6_XqpGfm+XHE1OzS=_+jroeDOxhhGa11P3cbm9q2gT05yorA@mail.gmail.com
Backpatch-through: 18
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/6b46a5d1b6164f2fdb15229dea9f3ed94ef20760
Modified Files
--------------
src/interfaces/libpq/fe-protocol3.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
view thread (3+ messages)
Message-ID: <E1wrADz-000000008WB-0AZI@gemulon.postgresql.org>
Permalink: ../E1wrADz-000000008WB-0AZI@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wrADz-000000008WB-0AZI@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix error handling in getCopyDataMessage() and pqFunctionCall3()
In-Reply-To: <E1wrADz-000000008WB-0AZI@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox