agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Prohibit GRANT ... ON TABLE on a property graph
Date: Tue, 04 Aug 2026 08:16:53 +0000
Message-ID: <E1wrAKT-000000008cy-20f1@gemulon.postgresql.org> (raw)

Prohibit GRANT ... ON TABLE on a property graph

We allowed GRANT ... ON TABLE on sequences for backward compatibility.
We don't need to consider backward compatibility in case of property
graphs since we will be prohibiting its usage on property graph from
the very release which introduced property graphs.

Change regression tests that used GRANT ... ON [TABLE] on property
graphs to use GRANT ... ON PROPERTY GRAPH instead.

While here, add the missing RELKIND_PROPGRAPH cases in
pg_class_aclmask_ext() and in the object-type switch in
ExecGrant_Relation() so that the default ACL and the objtype passed to
restrict_and_check_grant() are correct.

Author: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Reviewed-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/20260630023308.c7.noahmisch@microsoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fa62d4f6ea7529aa75105aa1ed3b43477ab365a0

Modified Files
--------------
src/backend/catalog/aclchk.c                        | 20 +++++++++++++++++++-
src/test/regress/expected/create_property_graph.out |  3 +++
src/test/regress/expected/graph_table_rls.out       |  6 +++---
src/test/regress/expected/privileges.out            |  4 ++--
src/test/regress/sql/create_property_graph.sql      |  1 +
src/test/regress/sql/graph_table_rls.sql            |  6 +++---
src/test/regress/sql/privileges.sql                 |  4 ++--
7 files changed, 33 insertions(+), 11 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1wrAKT-000000008cy-20f1@gemulon.postgresql.org>
Permalink:  ../E1wrAKT-000000008cy-20f1@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wrAKT-000000008cy-20f1@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Prohibit GRANT ... ON TABLE on a property graph
  In-Reply-To: <E1wrAKT-000000008cy-20f1@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox