agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Clarify wraparound warning percentage messages 2+ messages / 1 participants [nested] [flat]
* pgsql: Clarify wraparound warning percentage messages @ 2026-08-05 02:38 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Fujii Masao @ 2026-08-05 02:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Clarify wraparound warning percentage messages Commit e646450e609 added DETAIL messages for XID and MultiXactId wraparound warnings that described the reported percentage as the percentage of IDs available for use. However, the percentage is actually calculated from the remaining distance to the wraparound limit, not the stop limit where new IDs are refused. As a result, the wording could be misinterpreted as meaning that the reported percentage of IDs can still be allocated. Update the wording to clarify that the reported percentage represents the remaining transaction ID space or MultiXactId space before wraparound. Also update the related XID warning hints to use "transaction ID" terminology consistently. Backpatch to v19, where the DETAIL messages were added. Author: Fujii Masao <masao.fujii@gmail.com> Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com> Reviewed-by: Nathan Bossart <nathandbossart@gmail.com> Reviewed-by: Yugo Nagata <nagata@sraoss.co.jp> Discussion: https://postgr.es/m/CAHGQGwHWZTsR6bjdfpa+pOkBPjoXXm2LuJ+5nh+CvdyqEASHcQ@mail.gmail.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/dc6b6fe0a841f006db3f9a5752efbcb176f60e1c Modified Files -------------- doc/src/sgml/maintenance.sgml | 4 ++-- src/backend/access/transam/multixact.c | 8 ++++---- src/backend/access/transam/varsup.c | 14 +++++++------- src/test/modules/xid_wraparound/t/002_limits.pl | 3 ++- 4 files changed, 15 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Clarify wraparound warning percentage messages @ 2026-08-05 02:39 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Fujii Masao @ 2026-08-05 02:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Clarify wraparound warning percentage messages Commit e646450e609 added DETAIL messages for XID and MultiXactId wraparound warnings that described the reported percentage as the percentage of IDs available for use. However, the percentage is actually calculated from the remaining distance to the wraparound limit, not the stop limit where new IDs are refused. As a result, the wording could be misinterpreted as meaning that the reported percentage of IDs can still be allocated. Update the wording to clarify that the reported percentage represents the remaining transaction ID space or MultiXactId space before wraparound. Also update the related XID warning hints to use "transaction ID" terminology consistently. Backpatch to v19, where the DETAIL messages were added. Author: Fujii Masao <masao.fujii@gmail.com> Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com> Reviewed-by: Nathan Bossart <nathandbossart@gmail.com> Reviewed-by: Yugo Nagata <nagata@sraoss.co.jp> Discussion: https://postgr.es/m/CAHGQGwHWZTsR6bjdfpa+pOkBPjoXXm2LuJ+5nh+CvdyqEASHcQ@mail.gmail.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3d4216d85f42d9f011001367d5f962ca8d1d72e2 Modified Files -------------- doc/src/sgml/maintenance.sgml | 4 ++-- src/backend/access/transam/multixact.c | 8 ++++---- src/backend/access/transam/varsup.c | 14 +++++++------- src/test/modules/xid_wraparound/t/002_limits.pl | 3 ++- 4 files changed, 15 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-05 02:39 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-05 02:38 pgsql: Clarify wraparound warning percentage messages Fujii Masao <fujii@postgresql.org> 2026-08-05 02:39 pgsql: Clarify wraparound warning percentage messages Fujii Masao <fujii@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox