agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clarify wraparound warning percentage messages
Date: Wed, 05 Aug 2026 02:39:13 +0000
Message-ID: <E1wrRXF-00000000F5b-2VTn@gemulon.postgresql.org> (raw)

Clarify wraparound warning percentage messages

Commit e646450e609 added DETAIL messages for XID and MultiXactId
wraparound warnings that described the reported percentage as the
percentage of IDs available for use.  However, the percentage is actually
calculated from the remaining distance to the wraparound limit, not the
stop limit where new IDs are refused.  As a result, the wording could be
misinterpreted as meaning that the reported percentage of IDs can still
be allocated.

Update the wording to clarify that the reported percentage represents the
remaining transaction ID space or MultiXactId space before wraparound.

Also update the related XID warning hints to use "transaction ID"
terminology consistently.

Backpatch to v19, where the DETAIL messages were added.

Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Yugo Nagata <nagata@sraoss.co.jp>
Discussion: https://postgr.es/m/CAHGQGwHWZTsR6bjdfpa+pOkBPjoXXm2LuJ+5nh+CvdyqEASHcQ@mail.gmail.com
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3d4216d85f42d9f011001367d5f962ca8d1d72e2

Modified Files
--------------
doc/src/sgml/maintenance.sgml                   |  4 ++--
src/backend/access/transam/multixact.c          |  8 ++++----
src/backend/access/transam/varsup.c             | 14 +++++++-------
src/test/modules/xid_wraparound/t/002_limits.pl |  3 ++-
4 files changed, 15 insertions(+), 14 deletions(-)



view thread (2+ messages)

Message-ID: <E1wrRXF-00000000F5b-2VTn@gemulon.postgresql.org>
Permalink:  ../E1wrRXF-00000000F5b-2VTn@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wrRXF-00000000F5b-2VTn@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Clarify wraparound warning percentage messages
  In-Reply-To: <E1wrRXF-00000000F5b-2VTn@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox