agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Remove Subscription conninfo field; generate in caller. 2+ messages / 1 participants [nested] [flat]
* pgsql: Remove Subscription conninfo field; generate in caller. @ 2026-08-05 18:50 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-08-05 18:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove Subscription conninfo field; generate in caller. After server-based subscriptions, conninfo became more than just a catalog field. It has its own error paths, and it's important that callers that don't need conninfo don't encounter errors related to it. Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Reviewed-by: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6d04cd2b84496d727344be1acb6287452982c9bd Modified Files -------------- src/backend/catalog/pg_subscription.c | 105 ++++++++++++++----------- src/backend/commands/subscriptioncmds.c | 43 +++++++--- src/backend/replication/logical/sequencesync.c | 2 +- src/backend/replication/logical/tablesync.c | 2 +- src/backend/replication/logical/worker.c | 24 +++++- src/include/catalog/pg_subscription.h | 6 +- src/include/replication/worker_internal.h | 1 + 7 files changed, 118 insertions(+), 65 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Remove Subscription conninfo field; generate in caller. @ 2026-08-05 18:50 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-08-05 18:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove Subscription conninfo field; generate in caller. After server-based subscriptions, conninfo became more than just a catalog field. It has its own error paths, and it's important that callers that don't need conninfo don't encounter errors related to it. Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Reviewed-by: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8f7617ff7af60f4d9b2be0ba2d89b2fedbc027cc Modified Files -------------- src/backend/catalog/pg_subscription.c | 105 ++++++++++++++----------- src/backend/commands/subscriptioncmds.c | 43 +++++++--- src/backend/replication/logical/sequencesync.c | 2 +- src/backend/replication/logical/tablesync.c | 2 +- src/backend/replication/logical/worker.c | 24 +++++- src/include/catalog/pg_subscription.h | 6 +- src/include/replication/worker_internal.h | 1 + 7 files changed, 118 insertions(+), 65 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-05 18:50 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-05 18:50 pgsql: Remove Subscription conninfo field; generate in caller. Jeff Davis <jdavis@postgresql.org> 2026-08-05 18:50 pgsql: Remove Subscription conninfo field; generate in caller. Jeff Davis <jdavis@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox