agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove Subscription conninfo field; generate in caller.
Date: Wed, 05 Aug 2026 18:50:44 +0000
Message-ID: <E1wrghQ-00000000KkL-2ZAR@gemulon.postgresql.org> (raw)
Remove Subscription conninfo field; generate in caller.
After server-based subscriptions, conninfo became more than just a
catalog field. It has its own error paths, and it's important that
callers that don't need conninfo don't encounter errors related to it.
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/8f7617ff7af60f4d9b2be0ba2d89b2fedbc027cc
Modified Files
--------------
src/backend/catalog/pg_subscription.c | 105 ++++++++++++++-----------
src/backend/commands/subscriptioncmds.c | 43 +++++++---
src/backend/replication/logical/sequencesync.c | 2 +-
src/backend/replication/logical/tablesync.c | 2 +-
src/backend/replication/logical/worker.c | 24 +++++-
src/include/catalog/pg_subscription.h | 6 +-
src/include/replication/worker_internal.h | 1 +
7 files changed, 118 insertions(+), 65 deletions(-)
view thread (2+ messages)
Message-ID: <E1wrghQ-00000000KkL-2ZAR@gemulon.postgresql.org>
Permalink: ../E1wrghQ-00000000KkL-2ZAR@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wrghQ-00000000KkL-2ZAR@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove Subscription conninfo field; generate in caller.
In-Reply-To: <E1wrghQ-00000000KkL-2ZAR@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox