agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
pgsql: Be precise about when ALTER SUBSCRIPTION needs conninfo.
2+ messages / 1 participants
[nested] [flat]

* pgsql: Be precise about when ALTER SUBSCRIPTION needs conninfo.
@ 2026-08-05 20:13  Jeff Davis <jdavis@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Jeff Davis @ 2026-08-05 20:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Be precise about when ALTER SUBSCRIPTION needs conninfo.

Decide early whether the original conninfo is needed so that errors
happen consistently.

Addresses finding 12 in report from linked discussion.

Co-authored-by: Shlok Kyal <shlok.kyal.oss@gmail.com>
Reported-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e90e198e3f478ebc0b1fba0347ad9d76c48e7fa3

Modified Files
--------------
src/backend/commands/subscriptioncmds.c    | 79 +++++++++++++++++++-----------
src/test/regress/expected/subscription.out |  8 +++
src/test/regress/sql/subscription.sql      |  9 ++++
3 files changed, 68 insertions(+), 28 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Be precise about when ALTER SUBSCRIPTION needs conninfo.
@ 2026-08-05 20:14  Jeff Davis <jdavis@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Jeff Davis @ 2026-08-05 20:14 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Be precise about when ALTER SUBSCRIPTION needs conninfo.

Decide early whether the original conninfo is needed so that errors
happen consistently.

Addresses finding 12 in report from linked discussion.

Co-authored-by: Shlok Kyal <shlok.kyal.oss@gmail.com>
Reported-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ae420d66e72051b7ceab49d14f990094f1c8c6b4

Modified Files
--------------
src/backend/commands/subscriptioncmds.c    | 79 +++++++++++++++++++-----------
src/test/regress/expected/subscription.out |  8 +++
src/test/regress/sql/subscription.sql      |  9 ++++
3 files changed, 68 insertions(+), 28 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2026-08-05 20:14 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-08-05 20:13 pgsql: Be precise about when ALTER SUBSCRIPTION needs conninfo. Jeff Davis <jdavis@postgresql.org>
2026-08-05 20:14 pgsql: Be precise about when ALTER SUBSCRIPTION needs conninfo. Jeff Davis <jdavis@postgresql.org>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox