agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Be precise about when ALTER SUBSCRIPTION needs conninfo.
Date: Wed, 05 Aug 2026 20:14:10 +0000
Message-ID: <E1wri0A-00000000LC7-2fZz@gemulon.postgresql.org> (raw)
Be precise about when ALTER SUBSCRIPTION needs conninfo.
Decide early whether the original conninfo is needed so that errors
happen consistently.
Addresses finding 12 in report from linked discussion.
Co-authored-by: Shlok Kyal <shlok.kyal.oss@gmail.com>
Reported-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ae420d66e72051b7ceab49d14f990094f1c8c6b4
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 79 +++++++++++++++++++-----------
src/test/regress/expected/subscription.out | 8 +++
src/test/regress/sql/subscription.sql | 9 ++++
3 files changed, 68 insertions(+), 28 deletions(-)
view thread (2+ messages)
Message-ID: <E1wri0A-00000000LC7-2fZz@gemulon.postgresql.org>
Permalink: ../E1wri0A-00000000LC7-2fZz@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wri0A-00000000LC7-2fZz@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Be precise about when ALTER SUBSCRIPTION needs conninfo.
In-Reply-To: <E1wri0A-00000000LC7-2fZz@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox