agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: CREATE SUBSCRIPTION: do not construct conninfo unnecessarily.
Date: Wed, 05 Aug 2026 20:26:27 +0000
Message-ID: <E1wriC3-00000000LGC-3ojv@gemulon.postgresql.org> (raw)
CREATE SUBSCRIPTION: do not construct conninfo unnecessarily.
Still check that the creating user has USAGE privileges on the server,
and that the FDW supports subscription connections.
Addresses finding 1 in the report from the linked discussion.
Reported-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com
Discussion: https://postgr.es/m/e103ae8daf74485e0c0ebde297fae735d38f54d1.camel@j-davis.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/254beb174e61e339c43e1096053b0a0a2e9cf856
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 37 ++++++++++++++++++++++--------
src/backend/foreign/foreign.c | 4 ++--
src/test/regress/expected/subscription.out | 4 ++--
3 files changed, 31 insertions(+), 14 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wriC3-00000000LGC-3ojv@gemulon.postgresql.org>
Permalink: ../E1wriC3-00000000LGC-3ojv@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wriC3-00000000LGC-3ojv@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: CREATE SUBSCRIPTION: do not construct conninfo unnecessarily.
In-Reply-To: <E1wriC3-00000000LGC-3ojv@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox