agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: CREATE SUBSCRIPTION: do not construct conninfo unnecessarily. 2+ messages / 1 participants [nested] [flat]
* pgsql: CREATE SUBSCRIPTION: do not construct conninfo unnecessarily. @ 2026-08-05 20:26 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-08-05 20:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE SUBSCRIPTION: do not construct conninfo unnecessarily. Still check that the creating user has USAGE privileges on the server, and that the FDW supports subscription connections. Addresses finding 1 in the report from the linked discussion. Reported-by: Noah Misch <noah@leadboat.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Discussion: https://postgr.es/m/e103ae8daf74485e0c0ebde297fae735d38f54d1.camel@j-davis.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/254beb174e61e339c43e1096053b0a0a2e9cf856 Modified Files -------------- src/backend/commands/subscriptioncmds.c | 37 ++++++++++++++++++++++-------- src/backend/foreign/foreign.c | 4 ++-- src/test/regress/expected/subscription.out | 4 ++-- 3 files changed, 31 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: CREATE SUBSCRIPTION: do not construct conninfo unnecessarily. @ 2026-08-05 20:26 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-08-05 20:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE SUBSCRIPTION: do not construct conninfo unnecessarily. Still check that the creating user has USAGE privileges on the server, and that the FDW supports subscription connections. Addresses finding 1 in the report from the linked discussion. Reported-by: Noah Misch <noah@leadboat.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Discussion: https://postgr.es/m/e103ae8daf74485e0c0ebde297fae735d38f54d1.camel@j-davis.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1718a16433a3f6572e0ff9c64ef394ae8fec3765 Modified Files -------------- src/backend/commands/subscriptioncmds.c | 37 ++++++++++++++++++++++-------- src/backend/foreign/foreign.c | 4 ++-- src/test/regress/expected/subscription.out | 4 ++-- 3 files changed, 31 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-05 20:26 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-05 20:26 pgsql: CREATE SUBSCRIPTION: do not construct conninfo unnecessarily. Jeff Davis <jdavis@postgresql.org> 2026-08-05 20:26 pgsql: CREATE SUBSCRIPTION: do not construct conninfo unnecessarily. Jeff Davis <jdavis@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox