agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: When changing owner of a subscription, do not throw an error. 2+ messages / 1 participants [nested] [flat]
* pgsql: When changing owner of a subscription, do not throw an error. @ 2026-08-05 20:26 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-08-05 20:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org When changing owner of a subscription, do not throw an error. Errors will be caught when the connection is actually used. Restore uses multiple DDL commands to restore a subscription, so checks of the intermediate state risk restore errors. In the future we could address this with a more careful restoration order, but the DDL-time errors are merely for convenience. Addresses finding 2 in the report from the linked discussion. Reported-by: Noah Misch <noah@leadboat.com> Reviewed-by: Shlok Kyal <shlok.kyal.oss@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Discussion: https://postgr.es/m/e103ae8daf74485e0c0ebde297fae735d38f54d1.camel@j-davis.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7f4fb058076a8294933efa9f40378cbfb3b89ffd Modified Files -------------- src/backend/commands/subscriptioncmds.c | 24 +++++++----------------- src/test/regress/expected/subscription.out | 5 +++++ src/test/regress/sql/subscription.sql | 4 ++++ 3 files changed, 16 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: When changing owner of a subscription, do not throw an error. @ 2026-08-05 20:26 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-08-05 20:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org When changing owner of a subscription, do not throw an error. Errors will be caught when the connection is actually used. Restore uses multiple DDL commands to restore a subscription, so checks of the intermediate state risk restore errors. In the future we could address this with a more careful restoration order, but the DDL-time errors are merely for convenience. Addresses finding 2 in the report from the linked discussion. Reported-by: Noah Misch <noah@leadboat.com> Reviewed-by: Shlok Kyal <shlok.kyal.oss@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Discussion: https://postgr.es/m/e103ae8daf74485e0c0ebde297fae735d38f54d1.camel@j-davis.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a1e39c501d7a89a01c2738fecf7b66927e4e8bb7 Modified Files -------------- src/backend/commands/subscriptioncmds.c | 24 +++++++----------------- src/test/regress/expected/subscription.out | 5 +++++ src/test/regress/sql/subscription.sql | 4 ++++ 3 files changed, 16 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-05 20:26 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-05 20:26 pgsql: When changing owner of a subscription, do not throw an error. Jeff Davis <jdavis@postgresql.org> 2026-08-05 20:26 pgsql: When changing owner of a subscription, do not throw an error. Jeff Davis <jdavis@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox