agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: When changing owner of a subscription, do not throw an error.
Date: Wed, 05 Aug 2026 20:26:31 +0000
Message-ID: <E1wriC7-00000000LHP-0WlL@gemulon.postgresql.org> (raw)
When changing owner of a subscription, do not throw an error.
Errors will be caught when the connection is actually used.
Restore uses multiple DDL commands to restore a subscription, so
checks of the intermediate state risk restore errors. In the future we
could address this with a more careful restoration order, but the
DDL-time errors are merely for convenience.
Addresses finding 2 in the report from the linked discussion.
Reported-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Shlok Kyal <shlok.kyal.oss@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com
Discussion: https://postgr.es/m/e103ae8daf74485e0c0ebde297fae735d38f54d1.camel@j-davis.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a1e39c501d7a89a01c2738fecf7b66927e4e8bb7
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 24 +++++++-----------------
src/test/regress/expected/subscription.out | 5 +++++
src/test/regress/sql/subscription.sql | 4 ++++
3 files changed, 16 insertions(+), 17 deletions(-)
view thread (2+ messages)
Message-ID: <E1wriC7-00000000LHP-0WlL@gemulon.postgresql.org>
Permalink: ../E1wriC7-00000000LHP-0WlL@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wriC7-00000000LHP-0WlL@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: When changing owner of a subscription, do not throw an error.
In-Reply-To: <E1wriC7-00000000LHP-0WlL@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox