From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rename sort support integer comparators for clarity
Date: Mon, 10 Aug 2026 10:35:10 +0000
Message-ID: <E1wtNLa-00000000wq8-3vYm@gemulon.postgresql.org> (raw)
Rename sort support integer comparators for clarity
The previous names used "unsigned" for Datum-width abbreviated keys
and "signed" for 64-bit signed integers. This may have made more
sense when Datum width was platform-dependent, but commit 805c64f84
added a 32-bit unsigned variant for OIDs, so it makes even less sense
now. Rename all to be explicit about signedness and width.
Suggested-by: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAApHDvrNMz5ahN1x=uK9yscTogmLupfLBy-_qMW9Z+k=HE5u_A@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/19733fa0b42caffa92463bb8a8098a40d8963d76
Modified Files
--------------
src/backend/access/gist/gistproc.c | 2 +-
src/backend/access/nbtree/nbtcompare.c | 4 ++--
src/backend/utils/adt/bytea.c | 4 ++--
src/backend/utils/adt/mac.c | 4 ++--
src/backend/utils/adt/network.c | 2 +-
src/backend/utils/adt/timestamp.c | 2 +-
src/backend/utils/adt/uuid.c | 4 ++--
src/backend/utils/adt/varlena.c | 4 ++--
src/backend/utils/sort/tuplesort.c | 12 ++++++------
src/include/utils/sortsupport.h | 4 ++--
10 files changed, 21 insertions(+), 21 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: john.naylor@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rename sort support integer comparators for clarity
In-Reply-To: <E1wtNLa-00000000wq8-3vYm@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox