pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Rename sort support integer comparators for clarity
2+ messages / 2 participants
[nested] [flat]
* pgsql: Rename sort support integer comparators for clarity
@ 2026-08-10 10:35 John Naylor <john.naylor@postgresql.org>
2026-08-10 10:40 ` Re: pgsql: Rename sort support integer comparators for clarity John Naylor <johncnaylorls@gmail.com>
0 siblings, 1 reply; 2+ messages in thread
From: John Naylor @ 2026-08-10 10:35 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Rename sort support integer comparators for clarity
The previous names used "unsigned" for Datum-width abbreviated keys
and "signed" for 64-bit signed integers. This may have made more
sense when Datum width was platform-dependent, but commit 805c64f84
added a 32-bit unsigned variant for OIDs, so it makes even less sense
now. Rename all to be explicit about signedness and width.
Suggested-by: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAApHDvrNMz5ahN1x=uK9yscTogmLupfLBy-_qMW9Z+k=HE5u_A@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/19733fa0b42caffa92463bb8a8098a40d8963d76
Modified Files
--------------
src/backend/access/gist/gistproc.c | 2 +-
src/backend/access/nbtree/nbtcompare.c | 4 ++--
src/backend/utils/adt/bytea.c | 4 ++--
src/backend/utils/adt/mac.c | 4 ++--
src/backend/utils/adt/network.c | 2 +-
src/backend/utils/adt/timestamp.c | 2 +-
src/backend/utils/adt/uuid.c | 4 ++--
src/backend/utils/adt/varlena.c | 4 ++--
src/backend/utils/sort/tuplesort.c | 12 ++++++------
src/include/utils/sortsupport.h | 4 ++--
10 files changed, 21 insertions(+), 21 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: pgsql: Rename sort support integer comparators for clarity
2026-08-10 10:35 pgsql: Rename sort support integer comparators for clarity John Naylor <john.naylor@postgresql.org>
@ 2026-08-10 10:40 ` John Naylor <johncnaylorls@gmail.com>
0 siblings, 0 replies; 2+ messages in thread
From: John Naylor @ 2026-08-10 10:40 UTC (permalink / raw)
To: John Naylor <john.naylor@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
On Mon, Aug 10, 2026 at 5:35 PM John Naylor <john.naylor@postgresql.org> wrote:
> The previous names used "unsigned" for Datum-width abbreviated keys
> and "signed" for 64-bit signed integers. This may have made more
> sense when Datum width was platform-dependent, but commit 805c64f84
> added a 32-bit unsigned variant for OIDs, so it makes even less sense
> now. Rename all to be explicit about signedness and width.
Oops, the commit referred to here is actually 94d32ce1a, sorry for the noise.
--
John Naylor
Amazon Web Services
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-10 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-08-10 10:35 pgsql: Rename sort support integer comparators for clarity John Naylor <john.naylor@postgresql.org>
2026-08-10 10:40 ` John Naylor <johncnaylorls@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox