agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix pg_trgm's picksplit function with all-true datums
Date: Mon, 10 Aug 2026 13:41:22 +0000
Message-ID: <E1wtQFm-00000000y4f-1phK@gemulon.postgresql.org> (raw)

Fix pg_trgm's picksplit function with all-true datums

The CACHESIGN.sign field is a BITVECP, not a TRGM, so you should not
use GETSIGN() on it. You don't get a compiler warning because the
GETSIGN() macro includes a cast. It resulted in a bogus read beyond
end of buffer, which would cause bad split decisions or a crash if
you're very unlucky.

Reported-by: Mehmet D. INCE <mehmet@mehmetince.net>
Backpatch-through: 14
Security: CVE-2026-14678

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/aa7b5815ea099763b1cfe01e431b0ec8312c943f
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>

Modified Files
--------------
contrib/pg_trgm/trgm_gist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1wtQFm-00000000y4f-1phK@gemulon.postgresql.org>
Permalink:  ../E1wtQFm-00000000y4f-1phK@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wtQFm-00000000y4f-1phK@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix pg_trgm's picksplit function with all-true datums
  In-Reply-To: <E1wtQFm-00000000y4f-1phK@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox