agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Harden PL/Perl code against "tied" Perl arrays and hashes.
Date: Mon, 10 Aug 2026 13:41:23 +0000
Message-ID: <E1wtQFn-00000000y7b-44dT@gemulon.postgresql.org> (raw)
Harden PL/Perl code against "tied" Perl arrays and hashes.
Tied arrays might report different sizes each time they are inspected.
To avoid generating a corrupt result array, fix plperl_array_to_datum()
to read av_len() of each input array only once. If the input does
appear to get shorter, we'll fill nulls for the now-missing entries,
which seems fine. Conversely, if it gets longer, we'll ignore the new
entries.
plperl_to_hstore() assumed that Perl's hv_iterinit() returns the
number of entries in the given Perl hash. Usually that's true,
but per the Perl docs, "the return value is currently only meaningful
for hashes without tie magic". That could potentially end in a memory
stomp. We don't depend on that result value anywhere else, so don't
do so here either.
Reported-by: Hcamael <baiyjrh@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Backpatch-through: 14
Security: CVE-2026-14670
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/87c4b821972c9b66ced5520636c8ad4b60f8fd81
Author: Tom Lane <tgl@sss.pgh.pa.us>
Modified Files
--------------
contrib/hstore_plperl/hstore_plperl.c | 11 +++++++++--
src/pl/plperl/plperl.c | 6 +++++-
2 files changed, 14 insertions(+), 3 deletions(-)
view thread (6+ messages) latest in thread
Message-ID: <E1wtQFn-00000000y7b-44dT@gemulon.postgresql.org>
Permalink: ../E1wtQFn-00000000y7b-44dT@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wtQFn-00000000y7b-44dT@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Harden PL/Perl code against "tied" Perl arrays and hashes.
In-Reply-To: <E1wtQFn-00000000y7b-44dT@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox