agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove useless/confusing const qualifiers
Date: Tue, 11 Aug 2026 07:42:18 +0000
Message-ID: <E1wth7o-000000005dw-43dz@gemulon.postgresql.org> (raw)

Remove useless/confusing const qualifiers

The const qualifiers removed here did not qualify what is being
pointed to, which is the normal use in function prototypes.  Instead,
they qualify the variable itself, so that it cannot be changed inside
the function.  That is itself not wrong, but it's not a normal style,
and it seems distracting here.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/c855d318-4545-4dc7-b466-2e24fbf64725%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/370f3366c4c214abb0c34b2e2bd7fd42802112bf

Modified Files
--------------
src/bin/psql/describe.c      | 14 +++++++-------
src/fe_utils/print.c         | 20 ++++++++++----------
src/include/fe_utils/print.h | 18 +++++++++---------
3 files changed, 26 insertions(+), 26 deletions(-)



Message-ID: <E1wth7o-000000005dw-43dz@gemulon.postgresql.org>
Permalink:  ../E1wth7o-000000005dw-43dz@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wth7o-000000005dw-43dz@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove useless/confusing const qualifiers
  In-Reply-To: <E1wth7o-000000005dw-43dz@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox