agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: libpq: remove unused field ssl_handshake_started from PGconn
Date: Tue, 11 Aug 2026 20:09:58 +0000
Message-ID: <E1wtsnN-000000009hX-1dJx@gemulon.postgresql.org> (raw)
libpq: remove unused field ssl_handshake_started from PGconn
The ssl_handshake_started field was added by d39a49c1e45 to allow
connection_failed() skip retrying with a different SSL negotiation
method, once the server had reported an error after the TLS handshake
had already started. That logic was dropped by fb5718f35ff, which
removed the ability to fall back from direct to negotiated SSL, and
with it the only consumer of the data in this field. Fix by removing
the field.
Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/CAJ7c6TPkHjVFERp1Fd-idMe=iRJnDX2Nzy_ZOkV=y4OLLgf89Q@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bc86dc738e0e4c56a0635efd3d18b367b7e41f9b
Modified Files
--------------
src/interfaces/libpq/fe-secure-openssl.c | 4 ----
src/interfaces/libpq/libpq-int.h | 1 -
2 files changed, 5 deletions(-)
Message-ID: <E1wtsnN-000000009hX-1dJx@gemulon.postgresql.org>
Permalink: ../E1wtsnN-000000009hX-1dJx@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wtsnN-000000009hX-1dJx@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: libpq: remove unused field ssl_handshake_started from PGconn
In-Reply-To: <E1wtsnN-000000009hX-1dJx@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox