agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix unlink() error report in KeepFileRestoredFromArchive()
Date: Wed, 12 Aug 2026 00:56:44 +0000
Message-ID: <E1wtxGt-00000000BVq-1FxV@gemulon.postgresql.org> (raw)
Fix unlink() error report in KeepFileRestoredFromArchive()
KeepFileRestoredFromArchive() has been using an incorrect WAL segment
name in the error report for an unlink() failure.
Even without 1200dfd60c36, this was of consequence only on WIN32, where
we would miss to report a segment name suffixed by ".deleted%u".
Oversight in 60df192aea0e, for what looks like a copy-pasto to me.
Reported-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwHSbJnUmWCuF-QNUsGYF=iSSuzLRx1z_dLfYFwfbTu4Cw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/feb15361b34a1bbbc586ee3dc0ad970f6434aad3
Modified Files
--------------
src/backend/access/transam/xlogarchive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Message-ID: <E1wtxGt-00000000BVq-1FxV@gemulon.postgresql.org>
Permalink: ../E1wtxGt-00000000BVq-1FxV@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wtxGt-00000000BVq-1FxV@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix unlink() error report in KeepFileRestoredFromArchive()
In-Reply-To: <E1wtxGt-00000000BVq-1FxV@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox