agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
pgsql: Fix poll_query_until() timeout handling with an undefined query
7+ messages / 1 participants
[nested] [flat]

* pgsql: Fix poll_query_until() timeout handling with an undefined query
@ 2026-08-12 07:23 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2026-08-12 07:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix poll_query_until() timeout handling with an undefined query in Cluster.pm

On timeout, poll_query_until() would fail to print its report when
"$query" was undefined.  Instead of the expected report, this prevented
the contents of stdout and stderr from being shown.

Note that some of the in-core tests use an undefined query for
connection-only polls.

Author: Bryan Green <dbryan.green@gmail.com>
Reviewed-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Discussion: https://postgr.es/m/0f515c6d-6032-4c5f-80ac-5c78faae9522@gmail.com
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6828b03b062bf9eee7b5e5e7ee1cedd4e174ab29

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix poll_query_until() timeout handling with an undefined query
@ 2026-08-12 07:23 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2026-08-12 07:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix poll_query_until() timeout handling with an undefined query in Cluster.pm

On timeout, poll_query_until() would fail to print its report when
"$query" was undefined.  Instead of the expected report, this prevented
the contents of stdout and stderr from being shown.

Note that some of the in-core tests use an undefined query for
connection-only polls.

Author: Bryan Green <dbryan.green@gmail.com>
Reviewed-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Discussion: https://postgr.es/m/0f515c6d-6032-4c5f-80ac-5c78faae9522@gmail.com
Backpatch-through: 14

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7ff4ee83f7aeb5650e7783cced9d662381cbd94d

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix poll_query_until() timeout handling with an undefined query
@ 2026-08-12 07:23 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2026-08-12 07:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix poll_query_until() timeout handling with an undefined query in Cluster.pm

On timeout, poll_query_until() would fail to print its report when
"$query" was undefined.  Instead of the expected report, this prevented
the contents of stdout and stderr from being shown.

Note that some of the in-core tests use an undefined query for
connection-only polls.

Author: Bryan Green <dbryan.green@gmail.com>
Reviewed-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Discussion: https://postgr.es/m/0f515c6d-6032-4c5f-80ac-5c78faae9522@gmail.com
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cfa6884677ce05dce7fd1103c2fa1f71ce02d4b1

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix poll_query_until() timeout handling with an undefined query
@ 2026-08-12 07:23 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2026-08-12 07:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix poll_query_until() timeout handling with an undefined query in Cluster.pm

On timeout, poll_query_until() would fail to print its report when
"$query" was undefined.  Instead of the expected report, this prevented
the contents of stdout and stderr from being shown.

Note that some of the in-core tests use an undefined query for
connection-only polls.

Author: Bryan Green <dbryan.green@gmail.com>
Reviewed-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Discussion: https://postgr.es/m/0f515c6d-6032-4c5f-80ac-5c78faae9522@gmail.com
Backpatch-through: 14

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1cafef358c883857bb718cb83cf84436abb3e993

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix poll_query_until() timeout handling with an undefined query
@ 2026-08-12 07:23 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2026-08-12 07:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix poll_query_until() timeout handling with an undefined query in Cluster.pm

On timeout, poll_query_until() would fail to print its report when
"$query" was undefined.  Instead of the expected report, this prevented
the contents of stdout and stderr from being shown.

Note that some of the in-core tests use an undefined query for
connection-only polls.

Author: Bryan Green <dbryan.green@gmail.com>
Reviewed-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Discussion: https://postgr.es/m/0f515c6d-6032-4c5f-80ac-5c78faae9522@gmail.com
Backpatch-through: 14

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/37c4a0730f8e9230b8e15a33ec5ebd4dae24ca96

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix poll_query_until() timeout handling with an undefined query
@ 2026-08-12 07:23 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2026-08-12 07:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix poll_query_until() timeout handling with an undefined query in Cluster.pm

On timeout, poll_query_until() would fail to print its report when
"$query" was undefined.  Instead of the expected report, this prevented
the contents of stdout and stderr from being shown.

Note that some of the in-core tests use an undefined query for
connection-only polls.

Author: Bryan Green <dbryan.green@gmail.com>
Reviewed-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Discussion: https://postgr.es/m/0f515c6d-6032-4c5f-80ac-5c78faae9522@gmail.com
Backpatch-through: 14

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1511993de69f9d5d1c304ffb72a5d6c2c3d5622f

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix poll_query_until() timeout handling with an undefined query
@ 2026-08-12 07:23 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2026-08-12 07:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix poll_query_until() timeout handling with an undefined query in Cluster.pm

On timeout, poll_query_until() would fail to print its report when
"$query" was undefined.  Instead of the expected report, this prevented
the contents of stdout and stderr from being shown.

Note that some of the in-core tests use an undefined query for
connection-only polls.

Author: Bryan Green <dbryan.green@gmail.com>
Reviewed-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Discussion: https://postgr.es/m/0f515c6d-6032-4c5f-80ac-5c78faae9522@gmail.com
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d47336e5f6f1f20b4522d6073c30c6dbd5b07fb6

Modified Files
--------------
src/test/perl/PostgresNode.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2026-08-12 07:23 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-08-12 07:23 pgsql: Fix poll_query_until() timeout handling with an undefined query Michael Paquier <michael@paquier.xyz>
2026-08-12 07:23 pgsql: Fix poll_query_until() timeout handling with an undefined query Michael Paquier <michael@paquier.xyz>
2026-08-12 07:23 pgsql: Fix poll_query_until() timeout handling with an undefined query Michael Paquier <michael@paquier.xyz>
2026-08-12 07:23 pgsql: Fix poll_query_until() timeout handling with an undefined query Michael Paquier <michael@paquier.xyz>
2026-08-12 07:23 pgsql: Fix poll_query_until() timeout handling with an undefined query Michael Paquier <michael@paquier.xyz>
2026-08-12 07:23 pgsql: Fix poll_query_until() timeout handling with an undefined query Michael Paquier <michael@paquier.xyz>
2026-08-12 07:23 pgsql: Fix poll_query_until() timeout handling with an undefined query Michael Paquier <michael@paquier.xyz>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox