agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix poll_query_until() timeout handling with an undefined query
Date: Wed, 12 Aug 2026 07:23:54 +0000
Message-ID: <E1wu3JZ-00000000EC8-0gnH@gemulon.postgresql.org> (raw)

Fix poll_query_until() timeout handling with an undefined query in Cluster.pm

On timeout, poll_query_until() would fail to print its report when
"$query" was undefined.  Instead of the expected report, this prevented
the contents of stdout and stderr from being shown.

Note that some of the in-core tests use an undefined query for
connection-only polls.

Author: Bryan Green <dbryan.green@gmail.com>
Reviewed-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Discussion: https://postgr.es/m/0f515c6d-6032-4c5f-80ac-5c78faae9522@gmail.com
Backpatch-through: 14

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1511993de69f9d5d1c304ffb72a5d6c2c3d5622f

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1wu3JZ-00000000EC8-0gnH@gemulon.postgresql.org>
Permalink:  ../E1wu3JZ-00000000EC8-0gnH@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wu3JZ-00000000EC8-0gnH@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix poll_query_until() timeout handling with an undefined query
  In-Reply-To: <E1wu3JZ-00000000EC8-0gnH@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox