agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Fix stale comments/signature after commit 28d534e2ae0a 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix stale comments/signature after commit 28d534e2ae0a @ 2026-08-12 09:55 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 2+ messages in thread From: Álvaro Herrera @ 2026-08-12 09:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix stale comments/signature after commit 28d534e2ae0a Commit db89a47115f0 added an 'options' argument to table_tuple_update() and table_tuple_delete(), correctly documenting it as recognizing no values. It also (correctly) added pg_attribute_unused() to the corresponding heap_update() argument. Commit 28d534e2ae0a then added TABLE_UPDATE_NO_LOGICAL and TABLE_DELETE_NO_LOGICAL, but failed to (correctly) update the comment and heap_update()'s signature. In table_tuple_update(), move the correct explanation of 'options' to the right place, remove the bogus one. In table_tuple_delete(), add the missing TABLE_DELETE_NO_LOGICAL doc. In heap_update(), remove the pg_attribute_unused() marker. Author: Nikhil Sontakke <nikhil@planetscale.com> Backpatch-through: 19 Discussion: https://postgr.es/m/CA+UBoq21SzkjThYMSwSpVU-jwzpuEsf22Hq1FPbcKcDc43C29g@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b495c5685a1ac436a0006aba464efcf0edb6153d Modified Files -------------- src/backend/access/heap/heapam.c | 2 +- src/include/access/tableam.h | 14 +++++++++----- 2 files changed, 10 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix stale comments/signature after commit 28d534e2ae0a @ 2026-08-12 09:55 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 2+ messages in thread From: Álvaro Herrera @ 2026-08-12 09:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix stale comments/signature after commit 28d534e2ae0a Commit db89a47115f0 added an 'options' argument to table_tuple_update() and table_tuple_delete(), correctly documenting it as recognizing no values. It also (correctly) added pg_attribute_unused() to the corresponding heap_update() argument. Commit 28d534e2ae0a then added TABLE_UPDATE_NO_LOGICAL and TABLE_DELETE_NO_LOGICAL, but failed to (correctly) update the comment and heap_update()'s signature. In table_tuple_update(), move the correct explanation of 'options' to the right place, remove the bogus one. In table_tuple_delete(), add the missing TABLE_DELETE_NO_LOGICAL doc. In heap_update(), remove the pg_attribute_unused() marker. Author: Nikhil Sontakke <nikhil@planetscale.com> Backpatch-through: 19 Discussion: https://postgr.es/m/CA+UBoq21SzkjThYMSwSpVU-jwzpuEsf22Hq1FPbcKcDc43C29g@mail.gmail.com Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fd56954c9fe69bdc899d7cad93ec0b22b663cb30 Modified Files -------------- src/backend/access/heap/heapam.c | 2 +- src/include/access/tableam.h | 14 +++++++++----- 2 files changed, 10 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-12 09:55 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-12 09:55 pgsql: Fix stale comments/signature after commit 28d534e2ae0a Álvaro Herrera <alvherre@kurilemu.de> 2026-08-12 09:55 pgsql: Fix stale comments/signature after commit 28d534e2ae0a Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox