agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix stale comments/signature after commit 28d534e2ae0a
Date: Wed, 12 Aug 2026 09:55:08 +0000
Message-ID: <E1wu5fv-00000000FP8-1oPD@gemulon.postgresql.org> (raw)
Fix stale comments/signature after commit 28d534e2ae0a
Commit db89a47115f0 added an 'options' argument to table_tuple_update()
and table_tuple_delete(), correctly documenting it as recognizing no
values. It also (correctly) added pg_attribute_unused() to the
corresponding heap_update() argument. Commit 28d534e2ae0a then added
TABLE_UPDATE_NO_LOGICAL and TABLE_DELETE_NO_LOGICAL, but failed to
(correctly) update the comment and heap_update()'s signature.
In table_tuple_update(), move the correct explanation of 'options' to
the right place, remove the bogus one.
In table_tuple_delete(), add the missing TABLE_DELETE_NO_LOGICAL doc.
In heap_update(), remove the pg_attribute_unused() marker.
Author: Nikhil Sontakke <nikhil@planetscale.com>
Backpatch-through: 19
Discussion: https://postgr.es/m/CA+UBoq21SzkjThYMSwSpVU-jwzpuEsf22Hq1FPbcKcDc43C29g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b495c5685a1ac436a0006aba464efcf0edb6153d
Modified Files
--------------
src/backend/access/heap/heapam.c | 2 +-
src/include/access/tableam.h | 14 +++++++++-----
2 files changed, 10 insertions(+), 6 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1wu5fv-00000000FP8-1oPD@gemulon.postgresql.org>
Permalink: ../E1wu5fv-00000000FP8-1oPD@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wu5fv-00000000FP8-1oPD@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@kurilemu.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix stale comments/signature after commit 28d534e2ae0a
In-Reply-To: <E1wu5fv-00000000FP8-1oPD@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox