agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgcrypto: remove unused field mdc_checked from PGP_Context
Date: Thu, 13 Aug 2026 11:22:02 +0000
Message-ID: <E1wuTVZ-00000000OsI-1emB@gemulon.postgresql.org> (raw)
pgcrypto: remove unused field mdc_checked from PGP_Context
mdc_finish used to set this field once it had successfully verified
the MDC packet, with its only reader in the same function. This was
removed by a59ee881978 when mdc_finish stopped being called through
the pullf_read API, the field has been unused since.
Note that MDC verification does not rely on it: process_data_packets
tracks whether an MDC packet was seen in its local got_mdc variable
and rejects the message if a required MDC is missing, while the
use_mdcbuf_filter path checks the hash in mdcbuf_finish().
Author: Aleksander Alekseev <aleksander@tigerdata.com>
Discussion: https://postgr.es/m/CAJ7c6TNmHnnCkn3uZwRUE7WWYftW--48JFoDVDqoZqMrLYxUZw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e8a8ccc3ca192178fd3a179a06a91368008899dc
Modified Files
--------------
contrib/pgcrypto/pgp-decrypt.c | 1 -
contrib/pgcrypto/pgp.h | 1 -
2 files changed, 2 deletions(-)
Message-ID: <E1wuTVZ-00000000OsI-1emB@gemulon.postgresql.org>
Permalink: ../E1wuTVZ-00000000OsI-1emB@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wuTVZ-00000000OsI-1emB@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pgcrypto: remove unused field mdc_checked from PGP_Context
In-Reply-To: <E1wuTVZ-00000000OsI-1emB@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox