pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clarify logic in CreateSubscription().
Date: Sat, 15 Aug 2026 16:54:36 +0000
Message-ID: <E1wvHeV-00000000hCK-2q1v@gemulon.postgresql.org> (raw)

Clarify logic in CreateSubscription().

No bug found in previous code, but it unnecessarily relied on grammar
rules. Per complaint from Coverity.

Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/1787286.1786328153@sss.pgh.pa.us
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7b846015a40df872db572d92476d1e7c4e0c0066

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)



view thread (2+ messages)

Message-ID: <E1wvHeV-00000000hCK-2q1v@gemulon.postgresql.org>
Permalink:  ../E1wvHeV-00000000hCK-2q1v@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wvHeV-00000000hCK-2q1v@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Clarify logic in CreateSubscription().
  In-Reply-To: <E1wvHeV-00000000hCK-2q1v@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox