From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Re-register LSN waiters after stale wakeups
Date: Tue, 18 Aug 2026 12:02:13 +0000
Message-ID: <E1wwIWC-000000013YT-2Kk0@gemulon.postgresql.org> (raw)
Re-register LSN waiters after stale wakeups
WaitLSNWakeup() removes a waiter from the heap before setting its latch.
If the position that caused the wakeup moves backwards before the waiter
rechecks it, as can happen when WAL streaming restarts, the waiter may
sleep again while no longer registered. Subsequent WAL progress then
cannot wake it.
When an unmet waiter finds that it is no longer in the heap, add it back
and restart the loop. Rereading the position after registration also
prevents missing an advance between the previous read and the re-add.
Process interrupts before re-registering rather than after, so that a
wakeup which goes stale again cannot postpone cancellation, however often
it repeats. As a side effect, a pending cancel now wins over an expired
timeout, which previously reported a timeout instead.
Add deterministic TAP coverage that simulates a stale standby_write
wakeup without advancing the actual write or replay positions.
Author: Xuneng Zhou <xunengzhou@gmail.com>
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>
Discussion: https://postgr.es/m/CABPTF7UtW_cAa%3DQh4RDfKiUqu3pJJE22ai9tbWJVERbeRyssLw%40mail.gmail.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/70b7e968d5773026ea5105ae7ff23d362bf9723d
Modified Files
--------------
src/backend/access/transam/xlogwait.c | 37 +++++++-
src/test/modules/Makefile | 1 +
src/test/modules/meson.build | 1 +
src/test/modules/test_wait_lsn/Makefile | 21 +++++
src/test/modules/test_wait_lsn/meson.build | 22 +++++
.../modules/test_wait_lsn/test_wait_lsn--1.0.sql | 14 +++
src/test/modules/test_wait_lsn/test_wait_lsn.c | 99 ++++++++++++++++++++++
.../modules/test_wait_lsn/test_wait_lsn.control | 4 +
src/test/recovery/Makefile | 3 +-
src/test/recovery/t/049_wait_for_lsn.pl | 85 +++++++++++++++++++
10 files changed, 284 insertions(+), 3 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Re-register LSN waiters after stale wakeups
In-Reply-To: <E1wwIWC-000000013YT-2Kk0@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox