From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: test_json_parser: Fix broken file ref and inverted result check
Date: Tue, 18 Aug 2026 13:47:29 +0000
Message-ID: <E1wwKA4-000000014He-09iq@gemulon.postgresql.org> (raw)
test_json_parser: Fix broken file ref and inverted result check
A comma following a file ref in a perl print statement makes the
statement just print the file's GLOB rather than redirecting the
following arguments to the file. This meant the test was not testing any
contents and the logs were instead bulked up with what the test was
supposed to be testing.
Also, run_log() returns 1 for success, not 0, so the tests for the
return values were wrong. (We were getting 0 because of the comma error
above.)
Backpatch-thru: 17
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/195e8e427c07cc87ed8c8e819617bc87871893e5
Modified Files
--------------
src/test/modules/test_json_parser/t/004_test_parser_perf.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: test_json_parser: Fix broken file ref and inverted result check
In-Reply-To: <E1wwKA4-000000014He-09iq@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox