pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: test_json_parser: Fix broken file ref and inverted result check 4+ messages / 1 participants [nested] [flat]
* pgsql: test_json_parser: Fix broken file ref and inverted result check @ 2026-08-18 13:47 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 4+ messages in thread From: Andrew Dunstan @ 2026-08-18 13:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org test_json_parser: Fix broken file ref and inverted result check A comma following a file ref in a perl print statement makes the statement just print the file's GLOB rather than redirecting the following arguments to the file. This meant the test was not testing any contents and the logs were instead bulked up with what the test was supposed to be testing. Also, run_log() returns 1 for success, not 0, so the tests for the return values were wrong. (We were getting 0 because of the comma error above.) Backpatch-thru: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/195e8e427c07cc87ed8c8e819617bc87871893e5 Modified Files -------------- src/test/modules/test_json_parser/t/004_test_parser_perf.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: test_json_parser: Fix broken file ref and inverted result check @ 2026-08-18 13:47 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 4+ messages in thread From: Andrew Dunstan @ 2026-08-18 13:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org test_json_parser: Fix broken file ref and inverted result check A comma following a file ref in a perl print statement makes the statement just print the file's GLOB rather than redirecting the following arguments to the file. This meant the test was not testing any contents and the logs were instead bulked up with what the test was supposed to be testing. Also, run_log() returns 1 for success, not 0, so the tests for the return values were wrong. (We were getting 0 because of the comma error above.) Backpatch-thru: 17 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/96c34b1a8bb5b083c5f4cf5eee91e5edd63e8edd Modified Files -------------- src/test/modules/test_json_parser/t/004_test_parser_perf.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: test_json_parser: Fix broken file ref and inverted result check @ 2026-08-18 13:47 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 4+ messages in thread From: Andrew Dunstan @ 2026-08-18 13:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org test_json_parser: Fix broken file ref and inverted result check A comma following a file ref in a perl print statement makes the statement just print the file's GLOB rather than redirecting the following arguments to the file. This meant the test was not testing any contents and the logs were instead bulked up with what the test was supposed to be testing. Also, run_log() returns 1 for success, not 0, so the tests for the return values were wrong. (We were getting 0 because of the comma error above.) Backpatch-thru: 17 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/607c9033a39306fe10221d2211aa7f99125c4997 Modified Files -------------- src/test/modules/test_json_parser/t/004_test_parser_perf.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: test_json_parser: Fix broken file ref and inverted result check @ 2026-08-18 13:47 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 4+ messages in thread From: Andrew Dunstan @ 2026-08-18 13:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org test_json_parser: Fix broken file ref and inverted result check A comma following a file ref in a perl print statement makes the statement just print the file's GLOB rather than redirecting the following arguments to the file. This meant the test was not testing any contents and the logs were instead bulked up with what the test was supposed to be testing. Also, run_log() returns 1 for success, not 0, so the tests for the return values were wrong. (We were getting 0 because of the comma error above.) Backpatch-thru: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/10a6960632d4299324aaac69b25a9d9652b1fa0d Modified Files -------------- src/test/modules/test_json_parser/t/004_test_parser_perf.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2026-08-18 13:47 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-18 13:47 pgsql: test_json_parser: Fix broken file ref and inverted result check Andrew Dunstan <andrew@dunslane.net> 2026-08-18 13:47 pgsql: test_json_parser: Fix broken file ref and inverted result check Andrew Dunstan <andrew@dunslane.net> 2026-08-18 13:47 pgsql: test_json_parser: Fix broken file ref and inverted result check Andrew Dunstan <andrew@dunslane.net> 2026-08-18 13:47 pgsql: test_json_parser: Fix broken file ref and inverted result check Andrew Dunstan <andrew@dunslane.net>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox