From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move some node-read support functions from nodes.h to readfuncs.
Date: Mon, 24 Aug 2026 02:15:10 +0000
Message-ID: <E1wyKDN-00000001qJJ-0fx1@gemulon.postgresql.org> (raw)
Move some node-read support functions from nodes.h to readfuncs.h
The functions moved in this commit have been exposed since c1ddd2361f6e,
and there still seem to be a couple of projects out there that require
them, as they can be more efficient than nodeRead(). Note that all
these functions are only called in readfuncs.c in terms of the core
code.
A follow-up patch plans to improve the in-core support of pg_strtok(),
making it thread-safe. This change removes the need to expose internals
specific to node reads in nodes.h, which is a header with a more general
purpose than readfuncs.h.
Based on a suggestion by me.
Author: Matthias van de Meent <boekewurm+postgres@gmail.com>
Discussion: https://postgr.es/m/aofW6ntfWJjk_yBL@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/89d091f602fa59326d7cdf51e134e5525ef80977
Modified Files
--------------
src/include/nodes/nodes.h | 8 +-------
src/include/nodes/readfuncs.h | 6 ++++++
2 files changed, 7 insertions(+), 7 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move some node-read support functions from nodes.h to readfuncs.
In-Reply-To: <E1wyKDN-00000001qJJ-0fx1@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox