pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Align random test function parameters in test_bitmapset
2+ messages / 1 participants
[nested] [flat]

* pgsql: Align random test function parameters in test_bitmapset
@ 2026-08-24 22:43  David Rowley <drowley@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: David Rowley @ 2026-08-24 22:43 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Align random test function parameters in test_bitmapset

53a981ed5 adjusted test_random_offset_operations() so that the minimum
value parameter came before the maximum value parameter.  Here we adjust
test_random_operations() so that it accepts absolute numbers for the
minimum and maximum values.  Previously the maximum value to put in the
random Bitmapset was the minimum value plus the range.  Also align the
parameter order with test_random_offset_operations() to make these
functions consistent with each other.

Backpatch to v19 as test_random_operations() is new there.

Author: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Greg Burd <greg@burd.me>
Discussion: https://postgr.es/m/66d041b4-32f4-4097-bb2c-0e7147337a5e@app.fastmail.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d5d86704f4fddae04911e7784824429cbb2f6a84

Modified Files
--------------
.../test_bitmapset/expected/test_bitmapset.out     |  2 +-
.../modules/test_bitmapset/sql/test_bitmapset.sql  |  2 +-
src/test/modules/test_bitmapset/test_bitmapset.c   | 38 +++++++++++++---------
3 files changed, 24 insertions(+), 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Align random test function parameters in test_bitmapset
@ 2026-08-24 22:43  David Rowley <drowley@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: David Rowley @ 2026-08-24 22:43 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Align random test function parameters in test_bitmapset

53a981ed5 adjusted test_random_offset_operations() so that the minimum
value parameter came before the maximum value parameter.  Here we adjust
test_random_operations() so that it accepts absolute numbers for the
minimum and maximum values.  Previously the maximum value to put in the
random Bitmapset was the minimum value plus the range.  Also align the
parameter order with test_random_offset_operations() to make these
functions consistent with each other.

Backpatch to v19 as test_random_operations() is new there.

Author: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Greg Burd <greg@burd.me>
Discussion: https://postgr.es/m/66d041b4-32f4-4097-bb2c-0e7147337a5e@app.fastmail.com
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d6e4e22e9143749a9b629f2149e78edf2b6e0ec0

Modified Files
--------------
.../test_bitmapset/expected/test_bitmapset.out     |  2 +-
.../modules/test_bitmapset/sql/test_bitmapset.sql  |  2 +-
src/test/modules/test_bitmapset/test_bitmapset.c   | 38 +++++++++++++---------
3 files changed, 24 insertions(+), 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2026-08-24 22:43 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-08-24 22:43 pgsql: Align random test function parameters in test_bitmapset David Rowley <drowley@postgresql.org>
2026-08-24 22:43 pgsql: Align random test function parameters in test_bitmapset David Rowley <drowley@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox