From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Align random test function parameters in test_bitmapset
Date: Mon, 24 Aug 2026 22:43:24 +0000
Message-ID: <E1wydNz-00000001y33-39Q0@gemulon.postgresql.org> (raw)
Align random test function parameters in test_bitmapset
53a981ed5 adjusted test_random_offset_operations() so that the minimum
value parameter came before the maximum value parameter. Here we adjust
test_random_operations() so that it accepts absolute numbers for the
minimum and maximum values. Previously the maximum value to put in the
random Bitmapset was the minimum value plus the range. Also align the
parameter order with test_random_offset_operations() to make these
functions consistent with each other.
Backpatch to v19 as test_random_operations() is new there.
Author: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Greg Burd <greg@burd.me>
Discussion: https://postgr.es/m/66d041b4-32f4-4097-bb2c-0e7147337a5e@app.fastmail.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d6e4e22e9143749a9b629f2149e78edf2b6e0ec0
Modified Files
--------------
.../test_bitmapset/expected/test_bitmapset.out | 2 +-
.../modules/test_bitmapset/sql/test_bitmapset.sql | 2 +-
src/test/modules/test_bitmapset/test_bitmapset.c | 38 +++++++++++++---------
3 files changed, 24 insertions(+), 18 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Align random test function parameters in test_bitmapset
In-Reply-To: <E1wydNz-00000001y33-39Q0@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox