From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix signed/unsigned integer handling in pg_restore_relation_stat
Date: Tue, 25 Aug 2026 06:45:22 +0000
Message-ID: <E1wykuP-0000000214l-1jki@gemulon.postgresql.org> (raw)
Fix signed/unsigned integer handling in pg_restore_relation_stats()
The pg_class fields relpages, relallvisible, and relallfrozen are of
type int32, but the statistics restoration code and some statistics
code in postgres_fdw internally dealt with them as uint32 for a little
bit, after which they would turn back into int32. This doesn't make
sense, so fix it to use int32 consistently throughout.
In passing, change a float to float4 to similarly make the C type
consistent with the SQL type.
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/db993f34-e3e1-4e6e-85c3-4f248d2ff29b%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b345a554edf321e0ca53db0f4a69aac217805677
Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 23 +----------------------
src/backend/statistics/relation_stats.c | 26 +++++++++++++-------------
2 files changed, 14 insertions(+), 35 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix signed/unsigned integer handling in pg_restore_relation_stat
In-Reply-To: <E1wykuP-0000000214l-1jki@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox